[asterisk-dev] [Code Review] 2931: testsuite: check callerid pattern matching in dialplan and crash on reloading

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2931/#review10059
-----------------------------------------------------------

Ship it!


This looks good to go other than the minor issues below.


/asterisk/trunk/tests/pbx/dialplan_reload/run-test
<https://reviewboard.asterisk.org/r/2931/#comment19326>

    Unnecessary imports.



/asterisk/trunk/tests/pbx/dialplan_reload/run-test
<https://reviewboard.asterisk.org/r/2931/#comment19327>

    These are also unused.



/asterisk/trunk/tests/pbx/dialplan_reload/run-test
<https://reviewboard.asterisk.org/r/2931/#comment19328>

    Also unused.


- opticron


On Oct. 18, 2013, 12:53 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2931/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2013, 12:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AST-1235
>     https://issues.asterisk.org/jira/browse/AST-1235
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Test caller id matching in dialplan, including the difference between null length match string and an "any" match.
> 
> Also included is test for reloading the dialplan repeatedly with a null callerid match sequence to check for crash
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/pbx/tests.yaml 4263 
>   /asterisk/trunk/tests/pbx/dialplan_reload/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/pbx/dialplan_reload/run-test PRE-CREATION 
>   /asterisk/trunk/tests/pbx/dialplan_reload/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/pbx/callerid_match/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/pbx/callerid_match/sample7.call PRE-CREATION 
>   /asterisk/trunk/tests/pbx/callerid_match/sample6.call PRE-CREATION 
>   /asterisk/trunk/tests/pbx/callerid_match/sample5.call PRE-CREATION 
>   /asterisk/trunk/tests/pbx/callerid_match/sample4.call PRE-CREATION 
>   /asterisk/trunk/tests/pbx/callerid_match/sample3.call PRE-CREATION 
>   /asterisk/trunk/tests/pbx/callerid_match/sample2.call PRE-CREATION 
>   /asterisk/trunk/tests/pbx/callerid_match/sample1.call PRE-CREATION 
>   /asterisk/trunk/tests/pbx/callerid_match/run-test PRE-CREATION 
>   /asterisk/trunk/tests/pbx/callerid_match/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2931/diff/
> 
> 
> Testing
> -------
> 
> Tested on 1.8 with and without patch to AST-1235
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131031/7da6f3f2/attachment-0001.html>