[asterisk-dev] [Code Review] 2979: ari: Fix deadlock when originating multiple calls at once

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2979/#review10052
-----------------------------------------------------------

Ship it!


Ship It!

- rmudgett


On Oct. 31, 2013, 1:48 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2979/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 1:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22768
>     https://issues.asterisk.org/jira/browse/ASTERISK-22768
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently when a stasis application is specified when originating using ARI the application is subscribed to the originated channel. This is done while the channel lock is held, which is dangerous as the underlying code locks and iterates the channels container. The attached change releases the lock after getting a snapshot of the originated channel.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/ari/resource_channels.c 402138 
> 
> Diff: https://reviewboard.asterisk.org/r/2979/diff/
> 
> 
> Testing
> -------
> 
> Threw 10 originates at a time as fast as possible using ARI origination. Without patch there was a deadlock sporadically, with patch no deadlock.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131031/3def953d/attachment.html>