[asterisk-dev] [Code Review] 2973: Add equivalent AMI actions for the bridge CLI commands.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2973/#review10044
-----------------------------------------------------------



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19301>

    Guidelines.  Always use curly braces.



/branches/12/main/manager_bridges.c
<https://reviewboard.asterisk.org/r/2973/#comment19303>

    This should be changed to require one and only one to be present.
    
    Alternately, you can code it so that if both are present then the channel must be in the specified bridge to be kicked.



/branches/12/main/manager_bridges.c
<https://reviewboard.asterisk.org/r/2973/#comment19305>

    Use ast_channel_get_by_name() instead.  Otherwise, you may kick the wrong channel from the wrong bridge since the bridge is optional.



/branches/12/main/manager_bridges.c
<https://reviewboard.asterisk.org/r/2973/#comment19302>

    Lock the channel when calling.
    
    Also if the channel is not in a bridge then bridge is going to be returned as NULL.  This case is not handled.



/branches/12/main/manager_bridges.c
<https://reviewboard.asterisk.org/r/2973/#comment19304>

    Check return value to see if the kick was successful.


- rmudgett


On Oct. 30, 2013, 9:50 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2973/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 9:50 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22356
>     https://issues.asterisk.org/jira/browse/ASTERISK-22356
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds the following AMI events mirroring their CLI counterparts:
> 
> BridgeDestroy
> BridgeKick
> BridgeTechnologyList
> BridgeTechnologySuspend
> BridgeTechnologyUnsuspend
> 
> In the case of BridgeKick, to simplify the coding both a BridgeUniqueid and a Channel name must be provided to kick a channel.
> 
> The Technology calls are implemented in bridge.c due to the technology link list being located there.
> 
> Also in bridge.c, a new function ast_bridge_find_by_id() is added to expose the bridges ao2 container in a convenient fashion.
> 
> Tests for these AMI commands are here: https://reviewboard.asterisk.org/r/2975/
>  
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/manager_bridges.c 402126 
>   /branches/12/main/bridge.c 402126 
>   /branches/12/include/asterisk/bridge.h 402126 
> 
> Diff: https://reviewboard.asterisk.org/r/2973/diff/
> 
> 
> Testing
> -------
> 
> All tests written passed to insure basic functionality.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131030/fe464acb/attachment-0001.html>