[asterisk-dev] [Code Review] 2973: Add equivalent AMI actions for the bridge CLI commands.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2973/#review10039
-----------------------------------------------------------



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19275>

    stray blank line



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19278>

    bridging
    Fix all in this documentation block.  There are five or more.



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19276>

    stray blank line



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19274>

    How about moving this function to right after bridge_sort_cmp().  Existing ao2_find(bridges) calls could be converted to calling this function instead.



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19284>

    Manager action functions must not return non-zero.  Returning non-zero causes the AMI connection to be disconnected.



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19281>

    Delete as the value is unused.



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19282>

    Delete as the value is unused.



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19280>

    Stray blank line.



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19283>

    Same findings in this function as in manager_bridge_tech_suspend().
    
    In fact, these two functions can just call a helper function coded similarly to handle_bridge_technology_suspend() to suspend/unsuspend the technology.



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19285>

    I don't think you need to prefix these headers with Bridge.  The only exception could be BridgeTechnology.



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/2973/#comment19286>

    Guidelines.  Space after comma.



/branches/12/main/manager_bridges.c
<https://reviewboard.asterisk.org/r/2973/#comment19287>

    Use destroy instead of delete.



/branches/12/main/manager_bridges.c
<https://reviewboard.asterisk.org/r/2973/#comment19289>

    The parameter is required.
    The bridge is not being deleted.  It is being referenced.



/branches/12/main/manager_bridges.c
<https://reviewboard.asterisk.org/r/2973/#comment19293>

    This should be required also.  I don't think this action should do a kick all.  If you want a kick all use BridgeDestroy instead.



/branches/12/main/manager_bridges.c
<https://reviewboard.asterisk.org/r/2973/#comment19290>

    The bridge is not necessarily destroyed.



/branches/12/main/manager_bridges.c
<https://reviewboard.asterisk.org/r/2973/#comment19291>

    Manager actions must not return non-zero.



/branches/12/main/manager_bridges.c
<https://reviewboard.asterisk.org/r/2973/#comment19292>

    Guidelines.  Space after comma.


- rmudgett


On Oct. 29, 2013, 9:47 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2973/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2013, 9:47 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22356
>     https://issues.asterisk.org/jira/browse/ASTERISK-22356
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds the following AMI events mirroring their CLI counterparts:
> 
> BridgeDestroy
> BridgeKick
> BridgeTechnologyList
> BridgeTechnologySuspend
> BridgeTechnologyUnsuspend
> 
> In the case of BridgeKick, to simplify the coding both a BridgeUniqueid and a Channel name must be provided to kick a channel.
> 
> The Technology calls are implemented in bridge.c due to the technology link list being located there.
> 
> Also in bridge.c, a new function ast_bridge_find_by_id() is added to expose the bridges ao2 container in a convenient fashion.
> 
> Tests for these AMI commands are here: https://reviewboard.asterisk.org/r/2975/
>  
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/manager_bridges.c 402126 
>   /branches/12/main/bridge.c 402126 
>   /branches/12/include/asterisk/bridge.h 402126 
> 
> Diff: https://reviewboard.asterisk.org/r/2973/diff/
> 
> 
> Testing
> -------
> 
> All tests written passed to insure basic functionality.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131030/bfb56817/attachment-0001.html>