[asterisk-dev] [Code Review] 2905: Ensure RTP bridges are torn down on tech transition

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2905/#review10015
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On Oct. 22, 2013, 5:30 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2905/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2013, 5:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22628 and ASTERISK-22676
>     https://issues.asterisk.org/jira/browse/ASTERISK-22628
>     https://issues.asterisk.org/jira/browse/ASTERISK-22676
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When a bridge transitions away from one tech to another, the tech going away is provided a dummy bridge with no channels in it to tear down. Currently this means that the teardown code exits prematurely and does not tear anything down. This change tears down RTP bridging for the channel provided in the leave bridge tech callback.
> 
> This also reverts the majority of r400403 since it is redundant.
> 
> 
> Diffs
> -----
> 
>   branches/12/bridges/bridge_native_rtp.c 401086 
> 
> Diff: https://reviewboard.asterisk.org/r/2905/diff/
> 
> 
> Testing
> -------
> 
> This allows RTP bridge -> softmix tech transitions to pass audio correctly to phones instead of sending multiple streams simultaneously.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131028/2d1a15b8/attachment.html>