[asterisk-dev] [Code Review] 2939: ari recording: channel/bridge recording should fail if the format extension requested is unknown to Asterisk

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2939/#review9997
-----------------------------------------------------------

Ship it!


Good work.

- David Lee


On Oct. 18, 2013, 3:53 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2939/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2013, 3:53 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee, Joshua Colp, and kmoore.
> 
> 
> Bugs: ASTERISK-22626
>     https://issues.asterisk.org/jira/browse/ASTERISK-22626
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> If a recording is requested against a channel or bridge and an unknown format is used, Asterisk will accept the parameters and return success and then the recording will fail asynchronously. This patch makes Asterisk check the extension to make sure it's actually of a usable type so that we can return failure (422 specifically) before attempting to start the recording.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/ari/resource_bridges.c 401105 
>   /branches/12/res/ari/resource_channels.c 401105 
>   /branches/12/res/res_ari_bridges.c 401105 
>   /branches/12/res/res_ari_channels.c 401105 
>   /branches/12/rest-api/api-docs/bridges.json 401105 
>   /branches/12/rest-api/api-docs/channels.json 401105 
> 
> Diff: https://reviewboard.asterisk.org/r/2939/diff/
> 
> 
> Testing
> -------
> 
> Just the obvious.  Used format extension of 'fhqwhgads' and checked to see if it failed before and after the patch. It failed after, would be accepted before. Recordings never succeed of course, I'm just talking the HTTP response.
> 
> I've written a test similar to https://reviewboard.asterisk.org/r/2921/ for this, but I'll just let that test sit until that review goes somewhere.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131025/6e8a882b/attachment.html>