[asterisk-dev] [Code Review] 2921: Testsuite/Restful APIs: Add simple channel recording tests for file name conflicts with ifExist option

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2921/#review9996
-----------------------------------------------------------

Ship it!


Looks good!

- David Lee


On Oct. 16, 2013, 3:33 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2921/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 3:33 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee and kmoore.
> 
> 
> Bugs: ASTERISK-22623
>     https://issues.asterisk.org/jira/browse/ASTERISK-22623
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Adds a test that does some simple recording against a channel and then tries it over again with the same file name twice, once with expected failure due to ifExists being set to fail and the other time with expected success due to ifExists being set to overwrite.
> 
> As a bonus, I fixed the continue test.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/ari.py 4263 
>   /asterisk/trunk/tests/rest_api/bridges/hangup/bridge_hangup.py 4263 
>   /asterisk/trunk/tests/rest_api/bridges/happy/bridge_happy.py 4263 
>   /asterisk/trunk/tests/rest_api/bridges/move/bridge_move.py 4263 
>   /asterisk/trunk/tests/rest_api/bridges/unhappy/bridge_unhappy.py 4263 
>   /asterisk/trunk/tests/rest_api/continue/rest_continue.py 4263 
>   /asterisk/trunk/tests/rest_api/continue/test-config.yaml 4263 
>   /asterisk/trunk/tests/rest_api/recording/file_conflicts/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/recording/file_conflicts/recording.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/recording/file_conflicts/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/recording/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/tests.yaml 4263 
> 
> Diff: https://reviewboard.asterisk.org/r/2921/diff/
> 
> 
> Testing
> -------
> 
> New test fails against current 12 branches as expected.  I have a patch which fixes that and when applied, this test passes.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131025/510195e9/attachment.html>