[asterisk-dev] [Code Review] 2934: PJSIP: when identify by user doesn't match anything, add a debug log. When registration is received against an unidentifiable endpoint, add a notice log.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2934/
-----------------------------------------------------------

(Updated Oct. 23, 2013, 9:31 p.m.)


Review request for Asterisk Developers, Matt Jordan and Mark Michelson.


Changes
-------

Address mmichelson's review. New output format example:
[Oct 23 16:27:13] NOTICE[31221]: res_pjsip/pjsip_distributor.c:241 log_unidentified_request: Request from '"123" <sip:123 at 10.24.18.246>' failed for '10.24.18.240:5060' (callid: bac11944-835b600d-833b60b6 at 10.24.18.240) - No matching endpoint found

This is closer to chan_sip's error messages, just with the added callid information.


Bugs: ASTERISK-22552
    https://issues.asterisk.org/jira/browse/ASTERISK-22552


Repository: Asterisk


Description
-------

So currently, Asterisk displays nothing when a failed register happens against pjsip due to no endpoint matching the requesting user. That could be frustrating for people setting up new connections and chan_sip does issue messages of this nature.

This patch adds that along with some debug logging a specific endpoint identification method.


Diffs (updated)
-----

  /branches/12/res/res_pjsip/pjsip_distributor.c 401221 
  /branches/12/res/res_pjsip_endpoint_identifier_user.c 401221 

Diff: https://reviewboard.asterisk.org/r/2934/diff/


Testing
-------

Checked that information from failed registers would be received and that the debug messages would be written. Here's an example

res_pjsip_endpoint_identifier_user.c:106 username_identify: Could not identify endpoint by username '123'
res_pjsip/pjsip_distributor.c:258 log_unidentified_register: Registration from '10.24.18.246' failed for '123' - No matching endpoint found


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131023/7dcb0c3a/attachment.html>