[asterisk-dev] [Code Review] 2934: PJSIP: when identify by user doesn't match anything, add a debug log. When registration is received against an unidentifiable endpoint, add a notice log.

[jrose]

> On Oct. 21, 2013, 5 p.m., Mark Michelson wrote:
> > /branches/12/res/res_pjsip/pjsip_distributor.c, line 253
> > <https://reviewboard.asterisk.org/r/2934/diff/2/?file=47237#file47237line253>
> >
> >     Does this compile? I can't find where "name" is declared.

http://s24.postimg.org/7un4au0oz/name.png
I don't frequently post code that doesn't compile to reviewboard.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2934/#review9962
-----------------------------------------------------------


On Oct. 18, 2013, 7:04 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2934/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2013, 7:04 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and Mark Michelson.
> 
> 
> Bugs: ASTERISK-22552
>     https://issues.asterisk.org/jira/browse/ASTERISK-22552
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> So currently, Asterisk displays nothing when a failed register happens against pjsip due to no endpoint matching the requesting user. That could be frustrating for people setting up new connections and chan_sip does issue messages of this nature.
> 
> This patch adds that along with some debug logging a specific endpoint identification method.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip/pjsip_distributor.c 401221 
>   /branches/12/res/res_pjsip_endpoint_identifier_user.c 401221 
> 
> Diff: https://reviewboard.asterisk.org/r/2934/diff/
> 
> 
> Testing
> -------
> 
> Checked that information from failed registers would be received and that the debug messages would be written. Here's an example
> 
> res_pjsip_endpoint_identifier_user.c:106 username_identify: Could not identify endpoint by username '123'
> res_pjsip/pjsip_distributor.c:258 log_unidentified_register: Registration from '10.24.18.246' failed for '123' - No matching endpoint found
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131023/c069e230/attachment.html>