[asterisk-dev] [Code Review] 2909: ARI: Update for latest Swagger 1.2 spec

Matt Jordan reviewboard at asterisk.org
Tue Oct 22 14:09:09 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2909/#review9979
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Oct. 15, 2013, 2:40 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2909/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 2:40 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22440
>     https://issues.asterisk.org/jira/browse/ASTERISK-22440
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The Swagger 1.2 specification for type extension ended up being
> slightly different than my proposal. Instead of putting an 'extends'
> field on the subtype, the base type has a 'subTypes' field, which is a
> list of the subTypes. Given that its a messaging model and not an
> object model, kinda makes sense.
> 
> This patch changes the events.json api-doc, and the python translators
> to take the new format into account.
> 
> Other changes that are in Swagger 1.2 were not adopted, since the spec
> is still in flux, and could change before it's finalized.
> 
> A summary of changes to the Swagger-1.2 spec can be found at
> https://github.com/wordnik/swagger-core/wiki/1.2-transition.
> 
> 
> Diffs
> -----
> 
>   /branches/12/rest-api/api-docs/events.json 400969 
>   /branches/12/rest-api-templates/swagger_model.py 400969 
>   /branches/12/rest-api-templates/models.wiki.mustache 400969 
>   /branches/12/rest-api-templates/ari_model_validators.c.mustache 400969 
> 
> Diff: https://reviewboard.asterisk.org/r/2909/diff/
> 
> 
> Testing
> -------
> 
> Checked output of 'make ari-stubs' to ensure nothing changed.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131022/8c110db7/attachment.html>


More information about the asterisk-dev mailing list