[asterisk-dev] Asterisk 1.8.24.0 Now Available

[Matthew Jordan]

On Mon, Oct 21, 2013 at 8:17 PM, Olle E. Johansson <oej at edvina.net> wrote:

>
> 21 okt 2013 kl. 20:11 skrev "Asterisk Development Team" <
> asteriskteam at digium.com>:
>
> > * --- Fix Not Storing Current Incoming Recv Address
> >  (Closes issue ASTERISK-22071. Reported by Alex Zarubin)
> >
> > * --- Fix Segfault When Syntax Of A Line Under [applicationmap] Is
> >      Invalid
> >  (Closes issue ASTERISK-22416. Reported by CGI.NET)
> >
> > * --- Tolerate presence of RFC2965 Cookie2 header by ignoring it
> >  (Closes issue ASTERISK-21789. Reported by Stuart Henderson)
> >
> > * --- Fix Not Storing Current Incoming Recv Address
> >  (Closes issue ASTERISK-22071. Reported by Alex Zarubin)
>
> Fixing the same issue twice is powerful :-)
>
> I would kindly like to suggest that we add the module name to these
> reports - which
> module was the recv address fixed in and where was the cookie2 header?
>

Bah. I blame the person who chose those commits (/me looks around
suspiciously)

So I looked into this for a few minutes this morning. The script that
generates the e-mail bombs is using pysvn (along with the digium_commits
module in repotools) along with some JIRA integration to get the issue
information. According to the docs for pysvn [1], the log messages returned
from log() should contain a list of dictionaries containing information
about the changed paths in subversion. Theoretically, we could parse that
to find out what files were affected.

In practice, this attribute appears to be empty more often than not.

The other option is we follow the convention that commit messages should,
in their summary, list the affected modules. So the cookie summary should
be:

http: Tolerate presence of RFC2965 Cookie2 header by ignoring it

Some folks do this all the time; some don't. It isn't part of the
recommended commit message guidelines [2]. The downside of making it part
of the commit message guidelines is that it eats into the 80 character
limit for summaries and is (yet another) manual step.

I'll look into the PySVN returns some more to see if I can't figure out why
we're not getting the changed paths on some of the commits - if I can make
the change in the script, I will.

[1] http://pysvn.tigris.org/docs/pysvn_prog_ref.html#pysvn_client

[2] https://wiki.asterisk.org/wiki/display/AST/Commit+Messages

Matt

-- 
Matthew Jordan
Digium, Inc. | Engineering Manager
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: http://digium.com & http://asterisk.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131022/722726a1/attachment.html>