[asterisk-dev] [Code Review] 2942: Give parking timeout comebacktoorigin channel DTMF features.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2942/#review9956
-----------------------------------------------------------


Since the documentation changes are unrelated to the gist of this review, please make those in a separate commit.


/branches/12/res/parking/parking_bridge_features.c
<https://reviewboard.asterisk.org/r/2942/#comment19192>

    Err on the safe side and make this buffer larger.


- Mark Michelson


On Oct. 18, 2013, 11:30 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2942/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2013, 11:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22630
>     https://issues.asterisk.org/jira/browse/ASTERISK-22630
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Parking timeouts did not set any DTMF features for the channel calling the parker back.
> 
> * Added code to set the parkedcalltransfers, parkedcallreparking, parkedcallhangup, and parkedcallrecording options appropriately for the channels when a parking timeout occurs.  The recall channel DTMF options are set using the BRIDGE_FEATURES channel variable to allow the other timeout options to have the DTMF features available.
> 
> * Updated the configuration option XML documentation to indicate that the parkedcalltransfers, parkedcallreparking, parkedcallhangup, and parkedcallrecording options also apply to parking timeouts.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/parking/parking_bridge.c 401272 
>   /branches/12/res/parking/parking_bridge_features.c 401272 
>   /branches/12/res/res_parking.c 401272 
> 
> Diff: https://reviewboard.asterisk.org/r/2942/diff/
> 
> 
> Testing
> -------
> 
> Tested with comebacktoorigin=yes and parkedcallreparking=caller configured in the parking lot.
> Had A call B with the tTkK Dial option flags.
> Made A park B.
> When the parking timeout happens, A is called back and has the DTMF one-touch-parking feature enabled but does not have transfer ability.
> Without the patch A has no DTMF features.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131021/fc7ab454/attachment-0001.html>