[asterisk-dev] [Code Review] 2917: Correct behavior of ARI DELETE bridge command when channels are in the bridge.

[Mark Michelson]

> On Oct. 18, 2013, 1:15 p.m., opticron wrote:
> > This sounds like a deficiency in ast_bridge_destroy() since it does not remove channels properly if they are departable.
> 
> rmudgett wrote:
>     It is not the responsibility of ast_bridge_destroy() to deal with departable channels.  It is the responsibility of the code that put departable channels into the bridge system to take them out.  Departable channels are SPECIAL channels like announcers and recorders and should never be used for normal channel functionality.

I've added to the documentation of ast_bridge_destroy() in Asterisk 12 and trunk to indicate that departable channels in the bridge must be departed before destroying the bridge.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2917/#review9950
-----------------------------------------------------------


On Oct. 16, 2013, 5:39 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2917/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 5:39 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22634
>     https://issues.asterisk.org/jira/browse/ASTERISK-22634
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The ARI command to delete a bridge did not work properly when there were channels in the bridge. The reason is that the channels in the bridge were imparted and marked as departable. In order for the refcounts to work out properly when the bridge is removed, the chaannels need to be departed from the bridge.
> 
> The patch here is pretty simple, but I figured I'd put it up for review since it's my first foray into the land of ARI, and there may be some nuances that I have overlooked.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_stasis.c 401015 
> 
> Diff: https://reviewboard.asterisk.org/r/2917/diff/
> 
> 
> Testing
> -------
> 
> See https://reviewboard.asterisk.org/r/2818 for a testsuite test that exercises this.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131018/25ae0106/attachment.html>