[asterisk-dev] [Code Review] 2927: Remove Port Restriction When Checking For NAT

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2927/#review9949
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Oct. 17, 2013, 10:29 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2927/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2013, 10:29 p.m.)
> 
> 
> Review request for Asterisk Developers and wdoekes.
> 
> 
> Bugs: ASTERISK-22729
>     https://issues.asterisk.org/jira/browse/ASTERISK-22729
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Walter Doekes noted on another issue that the check_for_nat function in chan_sip is using the port and the address when checking for NAT.  We should only be using the address.
> 
> This patch removes the port from being used in this check for NAT.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_sip.c 401167 
> 
> Diff: https://reviewboard.asterisk.org/r/2927/diff/
> 
> 
> Testing
> -------
> 
> Local dev machine.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131018/5d4fa436/attachment.html>