[asterisk-dev] [Code Review] 2912: Test event for review 2913

Mark Michelson reviewboard at asterisk.org
Thu Oct 17 16:18:41 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2912/#review9945
-----------------------------------------------------------

Ship it!



/trunk/main/bridge_channel.c
<https://reviewboard.asterisk.org/r/2912/#comment19181>

    I know there aren't any tests that exercise the options yet, but it wouldn't add much overhead to go ahead and check for the other attended transfer menu options as well (atxferswap, atxferabort, and atxfercomplete).


- Mark Michelson


On Oct. 15, 2013, 7:41 p.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2912/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 7:41 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Test event for Asterisk 12/trunk that the test suite additions in review 2913 (https://reviewboard.asterisk.org/r/2913/) depend on.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/bridge_channel.c 401015 
> 
> Diff: https://reviewboard.asterisk.org/r/2912/diff/
> 
> 
> Testing
> -------
> 
> * Compiles
> * Proper event is received
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131017/340793fe/attachment.html>


More information about the asterisk-dev mailing list