[asterisk-dev] [Code Review] 2925: copy devstate (disable) caching flag when masquerading away local channels

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2925/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-22718
    https://issues.asterisk.org/jira/browse/ASTERISK-22718


Repository: Asterisk


Description
-------

See bug report. The AST_FLAG_DISABLE_DEVSTATE_CACHE gets set on local channels, but when ast_do_masquerade moves the endpoint into the local channel, the flag stays set. This leads to caching of Local channel state and discarding of SIP channel state.

In my case, the flag was disabled when setting the IN_USE state on my SIP device, but enabled when setting it to UNKNOWN again (after the masquerade). That meant that the device stayed IN_USE even though it was available again.


Diffs
-----

  /branches/1.8/main/channel.c 401166 

Diff: https://reviewboard.asterisk.org/r/2925/diff/


Testing
-------

Tested on asterisk 10 and 11 with (realtime) Local queuemembers with a SIP-device in the state_interface.

Without the fix, I got one call through and after that the queuemember was unavailable. With the fix, the queue behaved properly.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131017/4bcae21e/attachment.html>