[asterisk-dev] [Code Review] 2905: Ensure RTP bridges are torn down on tech transition

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2905/#review9930
-----------------------------------------------------------


After seeing this change and having a look at the native RTP bridge code as a whole, I think the change you've made would actually fit better inside of native_rtp_bridge_leave() instead of native_rtp_bridge_stop(). In addition, I would advise reverting SVN revision 400403 since it would be made irrelevant by this change.

- Mark Michelson


On Oct. 16, 2013, 1:33 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2905/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 1:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22676
>     https://issues.asterisk.org/jira/browse/ASTERISK-22676
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When a bridge transitions away from one tech to another, the tech going away is provided a dummy bridge with no channels in it to tear down. Currently this means that the teardown code exits prematurely and does not tear anything down. This change tears down RTP bridging for the channel provided in the leave bridge tech callback.
> 
> 
> Diffs
> -----
> 
>   branches/12/bridges/bridge_native_rtp.c 400862 
> 
> Diff: https://reviewboard.asterisk.org/r/2905/diff/
> 
> 
> Testing
> -------
> 
> This allows RTP bridge -> softmix tech transitions to pass audio correctly to phones instead of sending multiple streams simultaneously.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131016/1e705d0a/attachment-0001.html>