[asterisk-dev] [Code Review] 2916: ARI: Add early media playback, DTMF, and indications

[Paul Belanger]

> On Oct. 16, 2013, 6:38 p.m., Paul Belanger wrote:
> > /branches/12/rest-api/api-docs/channels.json, line 332
> > <https://reviewboard.asterisk.org/r/2916/diff/1/?file=47112#file47112line332>
> >
> >     correct me if I am wrong, but couldn't hold / unhold also be vaild options here?
> 
> Joshua Colp wrote:
>     Yes, they could be changed to go through indicate and just removed from elsewhere.

+1 for consistency.

I posted this to IRC, but will also do it here too: 

pabelanger> okay, so the more I did into file's patch about channel indications, I can see a lot of potential for it.  So much so, I think /answer and /hold could also be moved into it. Otherwise, I think we need to break it out so each indication has its own resource, /ringing /progress, /congestion, for consistency


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2916/#review9926
-----------------------------------------------------------


On Oct. 16, 2013, 3:41 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2916/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 3:41 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22701
>     https://issues.asterisk.org/jira/browse/ASTERISK-22701
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The attached patch adds some additional useful functionality:
> 
> 1. It is now possible to disable explicit answering when doing a playback, which can be used for early media.
> 
> 2. DTMF can now be posted to a channel which sends the DTMF to it.
> 
> 3. Indications can now be posted to a channel.
> 
> 
> Diffs
> -----
> 
>   /branches/12/include/asterisk/stasis_app.h 400957 
>   /branches/12/include/asterisk/stasis_app_playback.h 400957 
>   /branches/12/res/ari/resource_bridges.c 400957 
>   /branches/12/res/ari/resource_channels.h 400957 
>   /branches/12/res/ari/resource_channels.c 400957 
>   /branches/12/res/res_ari_channels.c 400957 
>   /branches/12/res/res_stasis_playback.c 400957 
>   /branches/12/res/stasis/control.c 400957 
>   /branches/12/rest-api/api-docs/channels.json 400957 
> 
> Diff: https://reviewboard.asterisk.org/r/2916/diff/
> 
> 
> Testing
> -------
> 
> Tested invoking everything as expected, plus off nominals (missing values, incorrect values).
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131016/2eceebab/attachment.html>