[asterisk-dev] [Code Review] 2916: ARI: Add early media playback, DTMF, and indications

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2916/#review9923
-----------------------------------------------------------



/branches/12/rest-api/api-docs/channels.json
<https://reviewboard.asterisk.org/r/2916/#comment19160>

    So, I'm conflicted with this options.  While I understand the need for early media, I believe this might actually belong in the application, and not ARI.
    
    Since we have /answer and /playback respectively, a combination of both could be used from the application POV to achieve early media.  If not, that's how I'd like to see it.
    
    Adding additional flags to function to control other function seems like a rabbit hole for a slew of different scenerios in ARI.


- Paul Belanger


On Oct. 16, 2013, 3:41 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2916/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 3:41 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22701
>     https://issues.asterisk.org/jira/browse/ASTERISK-22701
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The attached patch adds some additional useful functionality:
> 
> 1. It is now possible to disable explicit answering when doing a playback, which can be used for early media.
> 
> 2. DTMF can now be posted to a channel which sends the DTMF to it.
> 
> 3. Indications can now be posted to a channel.
> 
> 
> Diffs
> -----
> 
>   /branches/12/include/asterisk/stasis_app.h 400957 
>   /branches/12/include/asterisk/stasis_app_playback.h 400957 
>   /branches/12/res/ari/resource_bridges.c 400957 
>   /branches/12/res/ari/resource_channels.h 400957 
>   /branches/12/res/ari/resource_channels.c 400957 
>   /branches/12/res/res_ari_channels.c 400957 
>   /branches/12/res/res_stasis_playback.c 400957 
>   /branches/12/res/stasis/control.c 400957 
>   /branches/12/rest-api/api-docs/channels.json 400957 
> 
> Diff: https://reviewboard.asterisk.org/r/2916/diff/
> 
> 
> Testing
> -------
> 
> Tested invoking everything as expected, plus off nominals (missing values, incorrect values).
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131016/6e597c33/attachment.html>