[asterisk-dev] [Code Review] 2904: More consistent ARI error messages

David Lee reviewboard at asterisk.org
Tue Oct 15 09:04:25 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2904/#review9912
-----------------------------------------------------------


ast_ari_response_error(&response, 503, "Service unavailable", "Asterisk not booted")

^^ Do this to make my bad code better, and I'll totally ship it.

- David Lee


On Oct. 14, 2013, 1:02 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2904/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2013, 1:02 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Keep return messages more consistent, like ast_ari_response_error().  Note, a future patch would convert these responses to use ast_ari_response_error(), but my c foo is too weak to handle it.
> 
> 
> Diffs
> -----
> 
>   trunk/res/res_ari.c 400880 
> 
> Diff: https://reviewboard.asterisk.org/r/2904/diff/
> 
> 
> Testing
> -------
> 
> Local development box, with python-ari!
> 
> 
> Thanks,
> 
> Paul Belanger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131015/66f35d97/attachment-0001.html>


More information about the asterisk-dev mailing list