[asterisk-dev] [Code Review] 2880: CDRs: prevent backend modules from unregistering while active CDRs are in flight

[Matt Jordan]

> On Oct. 4, 2013, 7:35 p.m., Corey Farrell wrote:
> > /branches/12/cdr/cdr_manager.c, lines 90-94
> > <https://reviewboard.asterisk.org/r/2880/diff/3/?file=46984#file46984line90>
> >
> >     This should suspend for both reload and not.

Had to think about that one, but it is a possible edge case where we load, fail the config, unregister, unregister fails, and so we're technically "active" with no config and still registered. Yuck.


> On Oct. 4, 2013, 7:35 p.m., Corey Farrell wrote:
> > /branches/12/main/cdr.c, lines 2664-2668
> > <https://reviewboard.asterisk.org/r/2880/diff/3/?file=46993#file46993line2664>
> >
> >     This check should happen once the module is found, and only if the module is not suspended.
> >     1) It's always ok to unregister a suspended module.  For example cdr_manager is suspended by default config.
> >     2) It should never be an error if the module is not registered.
> >     
> >     Should error be -1 to allow direct use from unload_module procedures?  for example cdr_mysql could use the return from ast_cdr_unregister as the return for unload_module.

Fixed; updated to be -1.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2880/#review9893
-----------------------------------------------------------


On Oct. 4, 2013, 6:54 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2880/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2013, 6:54 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> During shutdown, Asterisk attempts to flush out any active CDRs by calling ast_cdr_engine_term. This is to try to get as much billing data recorded as possible before Asterisk shuts down/restarts and that data is lost. Unfortunately, module unloading occurs prior to calling ast_cdr_engine_term, and the CDR backend modules have already unregistered themselves. Thus, while the records are successfully flushed from the system, there are no registered backends left to handle the data.
> 
> This is technically a problem in prior versions of Asterisk as well; however, it is far less likely to occur in Asterisk 1.8/11 due to CDRs being build on an asynchronous message bus in Asterisk 12.
> 
> This patch modified ast_cdr_unregister such that if active_cdrs_by_channel has an entry, the unregistration fails. This would have the side effect of preventing CDR module unloading via the CLI on a busy system - but if you're doing that, you're already losing billing data, so that seems like a very bad idea anyway.
> 
> 
> Diffs
> -----
> 
>   /branches/12/addons/cdr_mysql.c 400541 
>   /branches/12/cdr/cdr_adaptive_odbc.c 400541 
>   /branches/12/cdr/cdr_csv.c 400541 
>   /branches/12/cdr/cdr_custom.c 400541 
>   /branches/12/cdr/cdr_manager.c 400541 
>   /branches/12/cdr/cdr_odbc.c 400541 
>   /branches/12/cdr/cdr_pgsql.c 400541 
>   /branches/12/cdr/cdr_radius.c 400541 
>   /branches/12/cdr/cdr_sqlite.c 400541 
>   /branches/12/cdr/cdr_sqlite3_custom.c 400541 
>   /branches/12/cdr/cdr_syslog.c 400541 
>   /branches/12/cdr/cdr_tds.c 400541 
>   /branches/12/include/asterisk/cdr.h 400541 
>   /branches/12/main/cdr.c 400541 
> 
> Diff: https://reviewboard.asterisk.org/r/2880/diff/
> 
> 
> Testing
> -------
> 
> The various dial tests that have a tendency to end very quickly while CDR data is in flight now pass consistently.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131004/a7e653eb/attachment-0001.html>