[asterisk-dev] [Code Review] 2901: Fix Regression With Queuelog EXITWITHKEY Only Logging Two Out Of Four Fields

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2901/#review9885
-----------------------------------------------------------

Ship it!


Ship It!

- rmudgett


On Oct. 3, 2013, 9:12 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2901/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2013, 9:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22197
>     https://issues.asterisk.org/jira/browse/ASTERISK-22197
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Commit r62462 added two extra fields for logging "the original position the caller entered the queue at, and the amount of time the caller was waiting in the queue."  But when r75969 was merged from 1.4 into trunk (r75977), these two fields disappeared. Those two extra fields were not logged in 1.4 and when the patch was merged, those fields went away.
> 
> Therefore, this is a regression and was caught by the reporter because he was reading the awesome "Asterisk: The Definitive Guide" book.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_queue.c 400452 
> 
> Diff: https://reviewboard.asterisk.org/r/2901/diff/
> 
> 
> Testing
> -------
> 
> Reporter tested the patch and confirmed that it restored the logging of these two fields.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131003/a7a20fd7/attachment.html>