[asterisk-dev] [Code Review] 2900: res_pjsip_logger: Add CLI command to disable logger or enable it globally or for an IP address

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2900/
-----------------------------------------------------------

(Updated Oct. 3, 2013, 9:16 p.m.)


Review request for Asterisk Developers, Joshua Colp and Mark Michelson.


Changes
-------

Address Josh and Mark's comments.


Repository: Asterisk


Description
-------

People might not appreciate that chan_pjsip's logger can only be turned on and off by means of loading and unloading the module.  This provides some of the functionality of sip set debug. Currently supported:

pjsip set logger on
pjsip set logger off
pjsip set logger ip <ip with or without port>

Also changed the tags so that the logger is installed by default (but will be off until you set the logger on)


Diffs (updated)
-----

  /branches/12/res/res_pjsip_logger.c 400284 

Diff: https://reviewboard.asterisk.org/r/2900/diff/


Testing
-------

Tested two endpoints to see if sip traffic came in when the logger was off.  It didn't.
Tested them both when logger was set on globally. It came in for both.
Tested that setting IP mode for a single IP address resulted in messages only happening for the endpoint with that IP address. Confirmed.
Tested that setting port in the address to something other than 5060 would result in no messages. Confirmed.
Tested that setting port in the address to 5060 would make the messages come in. Confirmed.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131003/7ac3d717/attachment-0001.html>