[asterisk-dev] [Code Review] 2660: Add IPv6 Support To chan_iax2

[Michael Young]

> On Aug. 30, 2013, 12:39 p.m., Mark Michelson wrote:
> > /trunk/channels/chan_iax2.c, lines 6089-6094
> > <https://reviewboard.asterisk.org/r/2660/diff/2/?file=45319#file45319line6089>
> >
> >     This can be simplified. You can get rid of str_taddr and str_tport altogether. In the debug message, just use ast_sockaddr_stringify() and it will print the address as "addr:port" properly.
> >     
> >     The way you have it may also output IPv6 addresses without square brackets, but I'm not sure about that.

You are right, it would have outputted IPv6 addresses without the brackets.


> On Aug. 30, 2013, 12:39 p.m., Mark Michelson wrote:
> > /trunk/channels/chan_iax2.c, lines 12087-12089
> > <https://reviewboard.asterisk.org/r/2660/diff/2/?file=45319#file45319line12087>
> >
> >     Would ast_sockaddr_isnull() be a suitable replacement for the individual address family checks?

Yes, that would be... not sure what craziness was going through my head here.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2660/#review9568
-----------------------------------------------------------


On Aug. 29, 2013, 12:29 a.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2660/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 12:29 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22025
>     https://issues.asterisk.org/jira/browse/ASTERISK-22025
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds the ability to bind and communicate over IPv6 addresses using chan_iax2.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/netsock.c 397908 
>   /trunk/main/acl.c 397908 
>   /trunk/include/asterisk/acl.h 397908 
>   /trunk/channels/iax2/parser.c 397908 
>   /trunk/channels/iax2/include/parser.h 397908 
>   /trunk/channels/iax2/include/iax2.h 397908 
>   /trunk/CHANGES 397908 
>   /trunk/channels/chan_iax2.c 397908 
> 
> Diff: https://reviewboard.asterisk.org/r/2660/diff/
> 
> 
> Testing
> -------
> 
> Successfully made calls using iax2 over IPv6 between two dev machines.  SIP Softphone -> dev vm (iax2 ipv6) -> (iax2 ipv6) dev box -> SIP ITSP -> mobile phone
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131003/7154604d/attachment-0001.html>