[asterisk-dev] [Code Review] 2892: res_pjsip: alembic script and sample configs for using realtime configuration with PJSIP

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2892/#review9875
-----------------------------------------------------------



/branches/12/contrib/ast-db-manage/config/versions/43956d550a44_add_tables_for_pjsip.py
<https://reviewboard.asterisk.org/r/2892/#comment19082>

    For all Enum types, add a name parameter. PostgreSQL script creation requires a name parameter on Enum types.
    
    For example:
    
    sa.Column('direct_media', sa.Enum(*YESNO_VALUES, name='yesno_values'))
    
    I used the nomenclature of name = lowercase(variable name), which seems to have worked out okay.



/branches/12/contrib/ast-db-manage/config/versions/43956d550a44_add_tables_for_pjsip.py
<https://reviewboard.asterisk.org/r/2892/#comment19083>

    Oracle databases only accept identifiers that are 30 characters or less. A few of these (this one in particular) may be a bit long - I'd shorten them up just a bit so that you don't run into that limitation.
    


- Matt Jordan


On Sept. 30, 2013, 6:37 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2892/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2013, 6:37 p.m.)
> 
> 
> Review request for Asterisk Developers, Joshua Colp, Matt Jordan, Mark Michelson, and Russell Bryant.
> 
> 
> Bugs: ASTERISK-22133
>     https://issues.asterisk.org/jira/browse/ASTERISK-22133
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Part of an effort to document the usage of realtime with PJSIP. This includes the ability to automatically build database tables for Endpoints, AORs, Authentication profiles, domain aliases, and endpoint identifiers. There also also some example configuration changes which provide linkage though sorcery.conf and extconfig.conf.  The extconfig samples assume ODBC is used, but they can be changed to any of the other back-ends fairly trivially for anyone who knows how to use them anyway.
> 
> A wiki page will also be written for this issue.
> 
> 
> Diffs
> -----
> 
>   /branches/12/configs/extconfig.conf.sample 399662 
>   /branches/12/configs/sorcery.conf.sample 399662 
>   /branches/12/contrib/ast-db-manage/config/versions/43956d550a44_add_tables_for_pjsip.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2892/diff/
> 
> 
> Testing
> -------
> 
> Generated the database tables with the alembic script
> Made PJSIP calls using realtime endpoints and AORs
> Tested that auths were created and could be read using the realtime backend provided by sorcery by means of a hastily chopped together CLI command (not included in the patch).  Domain aliases and endpoint identifier IPs haven't been directly tested, but the concept is the same.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131003/77526bf8/attachment.html>