[asterisk-dev] [Code Review] 3028: ari: Add 'number', 'digits', and 'characters' URI scheme playback implementations

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3028/#review10283
-----------------------------------------------------------



/branches/12/res/res_stasis_playback.c
<https://reviewboard.asterisk.org/r/3028/#comment19652>

    To reduce the amount of padding, move the bit fields to the end of the struct.



/branches/12/res/res_stasis_playback.c
<https://reviewboard.asterisk.org/r/3028/#comment19655>

    Should we invert this and return an error if there is no stored recording by that name?
    
    That is:
    
    recording = stasis_app_stored_recording_find_by_name(relname);
    if (!recording) {
        /* ERROR! */
    } else {
        playback->controllable = 1;
        ....
    }
    



/branches/12/res/res_stasis_playback.c
<https://reviewboard.asterisk.org/r/3028/#comment19656>

    I'd throw out an error here as well, at least to the CLI - %s not a valid number , etc.
    
    


- Matt Jordan


On Nov. 23, 2013, 2:35 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3028/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2013, 2:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There is currently no way in ARI to easily say a number, digits, or a string of characters. You can do it manually but this is extremely cumbersome. The attached change implements this functionality using new URI schemes in the Playback operation.
> 
> number:<number> will play the provided number
> digits:<digits> will play the provided digits
> characters:<characters> will play the provided characters
> 
> By using the existing playback operation these can be queued up just like any other sound file, allowing you to construct a complete sentence if you desire.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_stasis_playback.c 403119 
> 
> Diff: https://reviewboard.asterisk.org/r/3028/diff/
> 
> 
> Testing
> -------
> 
> Executed playback with the various URI schemes.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131126/c90d0f85/attachment.html>