[asterisk-dev] [Code Review] 3018: testsuite: Add tests for Say application jump behavior with SAY_DTMF_INTERRUPT enabled and disabled

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3018/#review10281
-----------------------------------------------------------



/asterisk/trunk/tests/apps/say_interrupt/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3018/#comment19646>

    Just for the sake of niceness, throw a Hangup at the end of the 'test' extension



/asterisk/trunk/tests/apps/say_interrupt/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3018/#comment19647>

    Add explicit hangups on these as well.



/asterisk/trunk/tests/apps/say_interrupt/test-config.yaml
<https://reviewboard.asterisk.org/r/3018/#comment19645>

    While it works just fine, I don't think you need to shout LOCAL. Local is just fine :-)


- Matt Jordan


On Nov. 15, 2013, 12:07 a.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3018/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 12:07 a.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and rmudgett.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> https://reviewboard.asterisk.org/r/3011/
> 
> Tests the functionality of this feature, both when set and not set
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/tests.yaml 4343 
>   /asterisk/trunk/tests/apps/say_interrupt/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/say_interrupt/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/say_interrupt/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3018/diff/
> 
> 
> Testing
> -------
> 
> It's a test.  It runs and completes successfully on my box with all the expected extensions being hit according to the logs. I changed some things around and was easily able to make it fail in ways that I expected it to fail, which is good. Changing the SAY_DTMF_INTERRUPT value in either test from what it currently is causes failures, which is also good. All DTMF values in the test must be issued for each test in order for the test to be considered successful.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131126/1a551b6d/attachment-0001.html>