[asterisk-dev] [Code Review] 3028: ari: Add 'number', 'digits', and 'characters' URI scheme playback implementations

Joshua Colp reviewboard at asterisk.org
Sat Nov 23 11:52:55 CST 2013



> On Nov. 23, 2013, 5:38 p.m., Paul Belanger wrote:
> > Wouldn't this be the same path as /dial? I know asterisk has native functionality to play numbers however, feel like libraries on top of ARI could handle this.  /me shrugs.
> 
> Joshua Colp wrote:
>     To play numbers in various languages is complicated... so every library would then need to implement that logic. It's non-trivial.
> 
> Paul Belanger wrote:
>     I agree, I don't think it would be trivial.  However, if ARI is basically to remove the app/* folder, maybe some of the heavy lifting needs to be done by the libraries.  I'm not opposed of having this functionality in ARI but do we want it in ARI is the question.
>     
>     Just look at the issue we have today with different languages and syntax in Asterisk, Steve even had a talk at Astridevcon about it.
>     
>     I'd rather see us expose the logic to have people write something, then embedded into ARI.

Nothing needs to be explicitly done to allow that, everything exists as sound files which can be played using the existing playback functionality.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3028/#review10268
-----------------------------------------------------------


On Nov. 23, 2013, 2:35 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3028/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2013, 2:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There is currently no way in ARI to easily say a number, digits, or a string of characters. You can do it manually but this is extremely cumbersome. The attached change implements this functionality using new URI schemes in the Playback operation.
> 
> number:<number> will play the provided number
> digits:<digits> will play the provided digits
> characters:<characters> will play the provided characters
> 
> By using the existing playback operation these can be queued up just like any other sound file, allowing you to construct a complete sentence if you desire.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_stasis_playback.c 403119 
> 
> Diff: https://reviewboard.asterisk.org/r/3028/diff/
> 
> 
> Testing
> -------
> 
> Executed playback with the various URI schemes.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131123/6065acae/attachment.html>


More information about the asterisk-dev mailing list