[asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

[Matt Jordan]

> On Nov. 14, 2013, 4:53 p.m., Mark Michelson wrote:
> > /branches/12/res/res_stasis_snoop.c, line 142
> > <https://reviewboard.asterisk.org/r/3003/diff/3/?file=48153#file48153line142>
> >
> >     Hm, would it be more useful to publish the snoop messages on the spyee channel's topic? I would suspect that most people would think of the spyee's channel as the "real" channel and would expect to see the publications on that channel instead of the snoop channel.
> 
> Joshua Colp wrote:
>     It's possible when spying is started to do that but doing it at the end and guaranteeing you get it would require holding a reference to the channel, which I avoided at all costs. As long as we're fine with that... then sure.

I'd prefer not, actually.

Usually, the channel that initiates the Spying is the one whose topic has the messages published on it. Granted, in this case, the Snoop channel is a little odd, but it is still the channel doing the Spying, not the target of the Spying operation. Switching the order of the channels here takes it out of alignment with the messages published in ChanSpy.

>From a consumer perspective, most things that receive ChanSpy messages have also already subscribed to the ast_channel_topic_all topic, which means the individual channel topics are kind of a moot point.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3003/#review10183
-----------------------------------------------------------


On Nov. 12, 2013, 6:43 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3003/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 6:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22780
>     https://issues.asterisk.org/jira/browse/ASTERISK-22780
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds a snoop operation to channels which allows spying and whispering to occur. The operation creates a Snoop channel, sends it into a provided Stasis application, and returns a snapshot of it. Once in the Stasis application any normal operation can be done with it (such as recording or placing into a bridge).
> 
> 
> Diffs
> -----
> 
>   /branches/12/rest-api/api-docs/channels.json 402707 
>   /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION 
>   /branches/12/res/res_stasis_snoop.c PRE-CREATION 
>   /branches/12/res/res_ari_channels.c 402707 
>   /branches/12/res/ari/resource_channels.c 402707 
>   /branches/12/res/ari/resource_channels.h 402707 
>   /branches/12/main/audiohook.c 402707 
>   /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3003/diff/
> 
> 
> Testing
> -------
> 
> Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon!
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131121/a7ed4c78/attachment.html>