[asterisk-dev] [Code Review] 3020: Test for consistent from tag on outbound REGISTER

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3020/#review10244
-----------------------------------------------------------

Ship it!


Extraneous white space and a suggestion. Nice work!


/asterisk/trunk/tests/channels/SIP/outbound_register_from/sipp/register.xml
<https://reviewboard.asterisk.org/r/3020/#comment19582>

    Red blob



/asterisk/trunk/tests/channels/SIP/outbound_register_from/test-config.yaml
<https://reviewboard.asterisk.org/r/3020/#comment19581>

    Not that we use it terribly often, but the YAML actually 'supports' a dedicated tag for issues:
    
    testinfo:
        # If true, skip execution of this test
        skip : 'Brief reason for skipping test' # OPTIONAL
        # A summary of what the test does
        summary: 'Put a short one liner summary of the test here'
        # A detailed description of what functionality is covered by the test
        description: |
            'Put a more verbose description of the test here.  This may span
            multiple lines.'
        # A sequence of key/value pairs specifying issues in an issue tracker related to this test
        issues: # OPTIONAL
            # List of issue numbers associated with this test
            - jira : 'ASTERISK-12345'
            - jira : 'ASTERISK-10101'
    
    It may be nice to put that in here, although it isn't necessary.



/asterisk/trunk/tests/channels/SIP/outbound_reregister_from/sipp/register.xml
<https://reviewboard.asterisk.org/r/3020/#comment19584>

    And here



/asterisk/trunk/tests/channels/SIP/outbound_reregister_from/sipp/register.xml
<https://reviewboard.asterisk.org/r/3020/#comment19583>

    Here too


- Matt Jordan


On Nov. 15, 2013, 9:42 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3020/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 9:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-12117
>     https://issues.asterisk.org/jira/browse/ASTERISK-12117
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This pair of tests were rewritten (from https://reviewboard.asterisk.org/r/2985/) to use SIPp instead of pcap which requires running as root.
> 
> The From header is examined by SIPp (acting as registrar) to insure that it is consistent for the duration of the test (reactor-timeout).  If it changes, SIPp aborts early to indicate a failure.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 4344 
>   /asterisk/trunk/tests/channels/SIP/outbound_reregister_from/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/outbound_reregister_from/sipp/register.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/outbound_reregister_from/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/outbound_register_from/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/outbound_register_from/sipp/register.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/outbound_register_from/configs/ast1/sip.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3020/diff/
> 
> 
> Testing
> -------
> 
> Ran the tests with 1.8 prior to r402604 (patch to 12117) and after.  Test properly indicates failure with unpatched code.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131121/10deff74/attachment-0001.html>