[asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

[Mark Michelson]

> On Nov. 21, 2013, 3:38 p.m., Joshua Colp wrote:
> > I don't see where the user event is actually checked... shouldn't you have specified the requirement of a Yay event in your test-config.yaml?
> 
> Mark Michelson wrote:
>     Nope, SimpleTestCase determines pass/fail based solely on the number of UserEvents that are received. So in my test, I send a UserEvent if the value is as expected; otherwise I NoOp. It doesn't matter what the content of the UserEvent is for SimpleTestCase, just that it exists.

Oh, and addition, specifying no configuration for SimpleTestCase defaults it to expecting 1 UserEvent in order to pass.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3024/#review10236
-----------------------------------------------------------


On Nov. 20, 2013, 9:12 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3024/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 9:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds a simple test that ensures the 'f' option to MixMonitor performs as documented.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/tests.yaml 4331 
>   /asterisk/trunk/tests/apps/mixmonitor_f_option/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/mixmonitor_f_option/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3024/diff/
> 
> 
> Testing
> -------
> 
> Test consistently passes.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131121/387b850f/attachment.html>