[asterisk-dev] [Code Review] 3015: Testsuite: CONFBRIDGE_RESULT test

Mark Michelson reviewboard at asterisk.org
Thu Nov 21 09:40:16 CST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 21, 2013, 3:40 p.m.)

Review request for Asterisk Developers.


Get full review up.

Repository: testsuite


This creates a test scenario that ensures that the five different CONFBRIDGE_RESULT values are set correctly upon exit. The test sets up a conference with five participants: Alice, Bob, Carol, Darnell, and Egbert.

Alice, Bob, and Carol enter initially. Alice has the "end_marked" option set on her user profile. Bob attempts to use a nonexistent user profile "sausage" to enter the conference, and Carol has access to a basic user DTMF menu. When Carol enters, this triggers Darnell to enter the conference. Darnell has access to a basic admin menu and is a marked user. It also triggers Carol to enter a DTMF sequence to leave the conference. When Darnell enters, this triggers Egbert to enter the conference. When Egbert enters, this triggers Darnell to press a DTMF sequence to kick Egbert out. When Egbert exits the conference, this triggers Darnell to hang up. Since Darnell is the final marked user in the conference, this should result in Alice being ejected from the conference.

Under this scenario, the CONFBRIDGE_RESULT variables should be as follows:
Carol: DTMF
Darnell: HANGUP
Egbert: KICKED

Diffs (updated)

  /asterisk/trunk/tests/apps/confbridge/tests.yaml 4331 
  /asterisk/trunk/tests/apps/confbridge/confbridge_result/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/confbridge/confbridge_result/configs/ast1/manager.general.conf.inc PRE-CREATION 
  /asterisk/trunk/tests/apps/confbridge/confbridge_result/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/confbridge/confbridge_result/configs/ast1/confbridge.conf PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/apptest.py 4331 

Diff: https://reviewboard.asterisk.org/r/3015/diff/


Ran the test in a while loop and ensured that in 30+ executions, the test passed each time.


Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131121/9b0ce704/attachment.html>

More information about the asterisk-dev mailing list