[asterisk-dev] [Code Review] 3009: Add channel variable that describes why a channel left a ConfBridge()

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3009/
-----------------------------------------------------------

(Updated Nov. 20, 2013, 5:35 p.m.)


Review request for Asterisk Developers.


Changes
-------

"ERROR" -> "FAILED"

"FAILED" is a more common channel variable settings for when an error occurs, so I have altered the value to be that instead.


Repository: Asterisk


Description
-------

This introduces a channel variable called CONFBRIDGE_RESULT that can be read after an invocation of ConfBridge in order to determine why the channel left. The possible values are:

* ERROR: The channel never joined the confbridge either due to bad input to the ConfBridge, an invalid PIN, or some internal error such as a memory allocation failure.
* HANGUP: The channel left the confbridge due to a soft or hard hangup.
* DTMF: The channel left due to the participant pressing a DTMF sequence to leave the ConfBridge.
* KICKED: The channel was removed from the conference either by an admin, or some outside command to kick the user from the conference.
* ENDMARKED: The channel was removed from the conference because it had the "endmarked" option enabled and the final marked user left the conference.

If there are ideas for other useful values, please let me know.


Diffs (updated)
-----

  /trunk/apps/confbridge/conf_state_multi_marked.c 402883 
  /trunk/apps/app_confbridge.c 402883 
  /trunk/CHANGES 402883 

Diff: https://reviewboard.asterisk.org/r/3009/diff/


Testing
-------

See review 3015


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131120/9722a400/attachment.html>