[asterisk-dev] [Code Review] 3021: Testsuite: Test that DIRECTORY_RESULT is set to the expected value under a set of test cases

[Jonathan Rose]

> On Nov. 18, 2013, 7:42 p.m., Mark Michelson wrote:
> > You can induce a "FAILED" scenario by calling Directory with a bogus dialcontext parameter. Perform the exact same test you would for trying to get the result to be "SELECTED". However, by providing an invalid dialcontext, the selected extension will not be found properly and should result in "FAILED" being set instead.

Alrighty, I've added the test and it works. I'll hold off on posting a new review until we've dealt with the whole 'FAILED' vs 'ERROR' thing.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3021/#review10208
-----------------------------------------------------------


On Nov. 15, 2013, 10:30 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3021/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 10:30 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan, Mark Michelson, and rmudgett.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> One test for each of the DIRECTORY_RESULT values except FAILED (since failed isn't actually intended to be possible under normal running conditions... as far as I know)
> 
> Uses the app test framework.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/tests.yaml 4344 
>   /asterisk/trunk/tests/apps/directory_operator_exit/test-config.yaml 4344 
>   /asterisk/trunk/tests/apps/directory_operator_exit/run-test 4344 
>   /asterisk/trunk/tests/apps/directory_operator_exit/configs/ast2/sip.conf 4344 
>   /asterisk/trunk/tests/apps/directory_operator_exit/configs/ast2/extensions.conf 4344 
>   /asterisk/trunk/tests/apps/directory_operator_exit/configs/ast1/sip.conf 4344 
>   /asterisk/trunk/tests/apps/directory_operator_exit/configs/ast1/extensions.conf 4344 
>   /asterisk/trunk/tests/apps/directory_context_operator_exit/test-config.yaml 4344 
>   /asterisk/trunk/tests/apps/directory_context_operator_exit/run-test 4344 
>   /asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast2/sip.conf 4344 
>   /asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast2/extensions.conf 4344 
>   /asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast1/sip.conf 4344 
>   /asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast1/extensions.conf 4344 
>   /asterisk/trunk/tests/apps/directory_attendant_exit/test-config.yaml 4344 
>   /asterisk/trunk/tests/apps/directory_attendant_exit/run-test 4344 
>   /asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast2/sip.conf 4344 
>   /asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast2/extensions.conf 4344 
>   /asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast1/sip.conf 4344 
>   /asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast1/extensions.conf 4344 
>   /asterisk/trunk/tests/apps/directory/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/directory/directory_result/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/directory/directory_result/configs/ast1/users.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/directory/directory_result/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3021/diff/
> 
> 
> Testing
> -------
> 
> Ran tests, confirmed that each event is issued and that the flow through the dialplan of the main test channel is consistent with each test case and issuing the correct user events.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131118/6c2775b7/attachment-0001.html>