[asterisk-dev] [Code Review] 3008: app_confbridge: Add an option 'announce_join_leave_review' for users that adds recording review to the 'announce_join_leave' name recording feature

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3008/#review10185
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Nov. 11, 2013, 11:53 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3008/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2013, 11:53 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Pretty straight forward really.  Adds the same basic functionality provided by the 'i' option to MeetMe into Confbridge (which already implemented functionality similar to the 'I' option through announce_join_leave)
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/confbridge.conf.sample 402603 
>   /trunk/apps/confbridge/include/confbridge.h 402603 
>   /trunk/apps/confbridge/conf_config_parser.c 402603 
>   /trunk/apps/app_confbridge.c 402603 
>   /trunk/CHANGES 402603 
> 
> Diff: https://reviewboard.asterisk.org/r/3008/diff/
> 
> 
> Testing
> -------
> 
> Made sure the recording feature worked with and without the review option in the expected way (with and without recording review). It's a pretty straight forward patch though.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131114/124968d3/attachment.html>