[asterisk-dev] [Code Review] 3010: CEL: Fix crash when using CELGenUserEvent

Mark Michelson reviewboard at asterisk.org
Thu Nov 14 11:06:54 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3010/#review10184
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Nov. 12, 2013, 4:26 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3010/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 4:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22799
>     https://issues.asterisk.org/jira/browse/ASTERISK-22799
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This fixes a crash when CELGenUserEvent is called from the dialplan while CEL is disabled. Currently, CEL does not create its topics and forwards if it is not enabled and external entities may depend on these topics blindly since they should always be available. This patch breaks up route creation and topic/forward creation such that the CEL topics and forwards will always exist while the router and its associated routes will be torn down and recreated as necessary.
> 
> 
> Diffs
> -----
> 
>   branches/12/main/cel.c 402708 
> 
> Diff: https://reviewboard.asterisk.org/r/3010/diff/
> 
> 
> Testing
> -------
> 
> Verified that the patch prevents the crash.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131114/45a850fa/attachment.html>


More information about the asterisk-dev mailing list