[asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels
Mark Michelson
reviewboard at asterisk.org
Thu Nov 14 10:53:27 CST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3003/#review10183
-----------------------------------------------------------
/branches/12/res/res_stasis_snoop.c
<https://reviewboard.asterisk.org/r/3003/#comment19498>
Hm, would it be more useful to publish the snoop messages on the spyee channel's topic? I would suspect that most people would think of the spyee's channel as the "real" channel and would expect to see the publications on that channel instead of the snoop channel.
- Mark Michelson
On Nov. 12, 2013, 6:43 p.m., Joshua Colp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3003/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2013, 6:43 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-22780
> https://issues.asterisk.org/jira/browse/ASTERISK-22780
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This patch adds a snoop operation to channels which allows spying and whispering to occur. The operation creates a Snoop channel, sends it into a provided Stasis application, and returns a snapshot of it. Once in the Stasis application any normal operation can be done with it (such as recording or placing into a bridge).
>
>
> Diffs
> -----
>
> /branches/12/rest-api/api-docs/channels.json 402707
> /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION
> /branches/12/res/res_stasis_snoop.c PRE-CREATION
> /branches/12/res/res_ari_channels.c 402707
> /branches/12/res/ari/resource_channels.c 402707
> /branches/12/res/ari/resource_channels.h 402707
> /branches/12/main/audiohook.c 402707
> /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION
>
> Diff: https://reviewboard.asterisk.org/r/3003/diff/
>
>
> Testing
> -------
>
> Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon!
>
>
> Thanks,
>
> Joshua Colp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131114/2fc707ff/attachment.html>
More information about the asterisk-dev
mailing list