[asterisk-dev] [Code Review] 2958: Testsuite - pjsip: AMI commands and events

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2958/#review10178
-----------------------------------------------------------



/asterisk/trunk/tests/channels/pjsip/ami/show_endpoint/configs/ast1/manager.users.conf.inc
<https://reviewboard.asterisk.org/r/2958/#comment19480>

    This should be unnecessary since the base config specifies:
    write = system,call,agent,user,config,command,reporting,originate,agi
    
    This applies to the remaining tests as well.



/asterisk/trunk/tests/channels/pjsip/ami/show_endpoint/configs/ast1/pjsip.conf
<https://reviewboard.asterisk.org/r/2958/#comment19477>

    This is redundant and applies to the remaining tests as well.


Limiting these test runs to a 7 second window is a bit short and should probably be bumped up.

- opticron


On Oct. 24, 2013, 10:43 a.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2958/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2013, 10:43 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22609
>     https://issues.asterisk.org/jira/browse/ASTERISK-22609
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Tests the following AMI actions and their corresponding events for res_pjsip:
> 
> PJSIPShowEndpoint
> PJSIPShowEndpoints
> PJSIPShowRegistrationsInbound
> PJSIPShowRegistrationsOutbound
> PJSIPShowSubscriptions
> 
> See https://reviewboard.asterisk.org/r/2959/ for implementation review.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/tests.yaml 4263 
>   /asterisk/trunk/tests/channels/pjsip/ami/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_subscriptions/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_subscriptions/sipp/subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_subscriptions/configs/ast1/voicemail.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_subscriptions/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_subscriptions/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_subscriptions/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_subscriptions/AMISendTest.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_outbound/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_outbound/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_outbound/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_outbound/AMISendTest.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_inbound/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_inbound/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_inbound/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_registrations_inbound/AMISendTest.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoints/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoints/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoints/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoints/AMISendTest.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoint/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoint/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoint/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoint/AMISendTest.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2958/diff/
> 
> 
> Testing
> -------
> 
> Ran tests and made sure they passed.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131113/712e84b4/attachment.html>