[asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

[Kevin Harwell]

> On Oct. 31, 2013, 4:43 p.m., George Joseph wrote:
> > How about adding auth_type_to_str and sip_for_each_auth to either res_pjsip.h or res_pjsip_private.h so I can use them for the CLI commands?
> >
> 
> George Joseph wrote:
>     And export them as well. :)
> 
> George Joseph wrote:
>     One more request :)
>     Can you refactor the ast_sip_for_each_xxx functions so the callbacks have the same signature that ao2_callback expects?  
>     
>     Example...
>     
>     ast_sip_for_each_aor takes in a comma-separated list of aors (from endpoint->aors), a callback, and args.  If I already have a container of aors though I can't use ao2_callback with the same callback because the signatures differ. Same for ast_sip_for_each_auth which takes in an array of auths.  I think those are the only 2 that take non-containers as inputs.
>     
>     Basically, the ast_sip_for_each_xxx functions would create and fill a container, then just pass the container to ao2_callback.
>     
>     
>

Yeah no problem and that makes more sense too.  I changed ast_sip_for_each_aor and ast_sip_for_each_auth to take ao2_callback_fn.  So if you have written a handler for an ao2_callback you can use the same one in these.  I left the iteration code in those functions the same though as I can't see a reason to add them to a container and then iterate over them a second time.

I didn't change ast_sip_for_each_contact though as that is a more specific case and had some extra parameters associated with it.  If you need that one changed as well it can be done, but with slightly more work is all (that is why I left it for now).


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2959/#review10083
-----------------------------------------------------------


On Nov. 12, 2013, 1:04 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2959/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 1:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22609
>     https://issues.asterisk.org/jira/browse/ASTERISK-22609
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Created the following AMI commands and corresponding events for res_pjsip:
> 
> PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few select attributes on each.
>   Events:
>     EndpointList - for each endpoint a few attributes
>     EndpointlistComplete - after all endpoints have been listed
> 
> PJSIPShowEndpoint - Provides a detail list of attributes for a specified endpoint
>   Events:
>     EndpointDetail - attributes on an endpoint
>     AorDetail - raised for each AOR on an endpoint
>     AuthDetail - raised for each associated inbound and outbound auth
>     TransportDetail - transport attributes
>     IdentifyDetail - attributes for the identify object associated with the endpoint
>     EndpointDetailComplete - last event raised after all detail events
> 
> PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound registrations
>   Events:
>     InboundRegistrationDetail - inbound registration attributes for each registration
>     InboundRegistrationDetailComplete - raised after all detail records have been listed
> 
> PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound registrations
>   Events:
>     OutboundRegistrationDetail - outbound registration attributes for each registration
>     OutboundRegistrationDetailComplete - raised after all detail records have been listed
> 
> PJSIPShowSubscriptions - A detail listing of all subscriptions and their attributes
>   Events:
>     SubscriptionDetail - on each subscription detailed attributes
>     SubscriptionDetailComplete - raised after all detail records have been listed
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_registrar.c 402377 
>   branches/12/res/res_pjsip_pubsub.c 402377 
>   branches/12/res/res_pjsip_outbound_registration.c 402377 
>   branches/12/res/res_pjsip_mwi.c 402377 
>   branches/12/res/res_pjsip_exten_state.c 402377 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 402377 
>   branches/12/res/res_pjsip/pjsip_configuration.c 402377 
>   branches/12/res/res_pjsip/location.c 402377 
>   branches/12/res/res_pjsip/include/res_pjsip_private.h 402377 
>   branches/12/res/res_pjsip/config_transport.c 402377 
>   branches/12/res/res_pjsip/config_auth.c 402377 
>   branches/12/res/res_pjsip.exports.in 402377 
>   branches/12/res/res_pjsip.c 402377 
>   branches/12/main/utils.c 402377 
>   branches/12/main/sorcery.c 402377 
>   branches/12/main/acl.c 402377 
>   branches/12/include/asterisk/strings.h 402377 
>   branches/12/include/asterisk/sorcery.h 402377 
>   branches/12/include/asterisk/res_pjsip_pubsub.h 402377 
>   branches/12/include/asterisk/res_pjsip.h 402377 
>   branches/12/include/asterisk/acl.h 402377 
> 
> Diff: https://reviewboard.asterisk.org/r/2959/diff/
> 
> 
> Testing
> -------
> 
> Ran a few manual tests over AMI and observed the output to make sure things look correct.  Also wrote some testsuite tests: https://reviewboard.asterisk.org/r/2958/
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131112/1e72ffbb/attachment-0001.html>