[asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

[Joshua Colp]

> On Nov. 11, 2013, 10:16 p.m., Matt Jordan wrote:
> > /branches/12/res/res_stasis_snoop.c, lines 180-187
> > <https://reviewboard.asterisk.org/r/3003/diff/1/?file=48080#file48080line180>
> >
> >     In general, 99% of the system won't ever want to 'know' about a Snoop channel. This should be flagged with the internal implementation details flag.
> >     
> >     I'm not sure whether or not we will want to see events for this particular channel technology through ARI. That should get interesting to resolve with Kinsey's filtering patch.

Yeah... I've now marked it as such but I foresee this causing issues. While the Snoop channel is an implementation detail to snooping it is not one to bridging. It has the same properties as any other channel in a bridge. It's safe to do anything to it.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3003/#review10163
-----------------------------------------------------------


On Nov. 12, 2013, 12:16 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3003/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 12:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22780
>     https://issues.asterisk.org/jira/browse/ASTERISK-22780
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds a snoop operation to channels which allows spying and whispering to occur. The operation creates a Snoop channel, sends it into a provided Stasis application, and returns a snapshot of it. Once in the Stasis application any normal operation can be done with it (such as recording or placing into a bridge).
> 
> 
> Diffs
> -----
> 
>   /branches/12/rest-api/api-docs/channels.json 402707 
>   /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION 
>   /branches/12/res/res_stasis_snoop.c PRE-CREATION 
>   /branches/12/res/res_ari_channels.c 402707 
>   /branches/12/res/ari/resource_channels.c 402707 
>   /branches/12/res/ari/resource_channels.h 402707 
>   /branches/12/main/audiohook.c 402707 
>   /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3003/diff/
> 
> 
> Testing
> -------
> 
> Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon!
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131112/a4a1b4cb/attachment-0001.html>