[asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3003/#review10162
-----------------------------------------------------------



/branches/12/res/res_stasis_snoop.c
<https://reviewboard.asterisk.org/r/3003/#comment19437>

    You're probably being a bit aggressive with this channel lock. Technically, you don't need to hold this lock until you start to get the formats from the channel - probably around line 280. Then, you only need to hold it until you're done calling snoop_setup_audiohook. Maybe a block to scope the lock would be appropriate?



/branches/12/rest-api/api-docs/channels.json
<https://reviewboard.asterisk.org/r/3003/#comment19435>

    I'm curious: what does 'spy=to' actually do? In the same vein, what does 'whisper=from' do?
    



/branches/12/rest-api/api-docs/channels.json
<https://reviewboard.asterisk.org/r/3003/#comment19436>

    If a valid option is 'none'; should this option just not be required?


- Matt Jordan


On Nov. 9, 2013, 1:56 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3003/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2013, 1:56 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22780
>     https://issues.asterisk.org/jira/browse/ASTERISK-22780
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds a snoop operation to channels which allows spying and whispering to occur. The operation creates a Snoop channel, sends it into a provided Stasis application, and returns a snapshot of it. Once in the Stasis application any normal operation can be done with it (such as recording or placing into a bridge).
> 
> 
> Diffs
> -----
> 
>   /branches/12/rest-api/api-docs/channels.json 402644 
>   /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION 
>   /branches/12/res/res_stasis_snoop.c PRE-CREATION 
>   /branches/12/res/res_ari_channels.c 402644 
>   /branches/12/res/ari/resource_channels.c 402644 
>   /branches/12/res/ari/resource_channels.h 402644 
>   /branches/12/main/audiohook.c 402644 
>   /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3003/diff/
> 
> 
> Testing
> -------
> 
> Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon!
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131111/8e5afff7/attachment.html>