[asterisk-dev] [Code Review] 3002: pjsip: convert configuration settings names to snake case

Kevin Harwell reviewboard at asterisk.org
Fri Nov 8 16:27:14 CST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 8, 2013, 4:27 p.m.)

Review request for Asterisk Developers.


I guess I didn't hit "ok" on the testing done field before publishing.

Repository: Asterisk


Renamed, where appropriate, the configuration options for chan/res_pjsip to use snake case (compound words separated by an underscore).  For example, faxdetect will become fax_detect, recordofffeature will become record_off_feature, etc...


  branches/12/res/res_pjsip_acl.c 402562 
  branches/12/res/res_pjsip/pjsip_configuration.c 402562 
  branches/12/res/res_pjsip/config_transport.c 402562 
  branches/12/res/res_pjsip/config_system.c 402562 
  branches/12/res/res_pjsip/config_global.c 402562 
  branches/12/res/res_pjsip.c 402562 
  branches/12/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py 402562 

Diff: https://reviewboard.asterisk.org/r/3002/diff/

Testing (updated)

Started asterisk with a basic pjsip configuration to make sure things still loaded/ran correctly.


Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131108/6dffa3e4/attachment.html>

More information about the asterisk-dev mailing list