[asterisk-dev] [Code Review] 2995: app_queue: Honor penalty limits of 0

opticron reviewboard at asterisk.org
Mon Nov 4 16:02:45 CST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 4, 2013, 4:02 p.m.)

Review request for Asterisk Developers.


Fix red blob.

Bugs: ASTERISK-20862

Repository: Asterisk


In the current app_queue code from 1.8 up to trunk the upper and lower penalties can be set to 0 but the value is interpreted to be disabled instead of actually setting limits. This is especially evident if min and max limits are set to 0 and members with penalties of 0 and 1 are in the queue since the member with penalty 1 will still receive calls. This patch adjusts the special disabled value to be INT_MAX instead of 0.

Diffs (updated)

  branches/1.8/apps/app_queue.c 402335 

Diff: https://reviewboard.asterisk.org/r/2995/diff/


Manual testing of the scenario described above.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131104/aa98750d/attachment.html>

More information about the asterisk-dev mailing list