[asterisk-dev] [Code Review] 2960: confbridge: Separate user muting from system muting overrides.

[svnbot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2960/
-----------------------------------------------------------

(Updated Nov. 1, 2013, 9:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 402425


Bugs: AST-1102
    https://issues.asterisk.org/jira/browse/AST-1102


Repository: Asterisk


Description
-------

The system overrides the user muting requests when MOH is playing or a waitmarked user is waiting for a marked user to join.  System muting overrides interfere with what the user may wish the muting to be when the system override ends.

* User muting requests are now independent of the system muting overrides.  The effective muting is now the logical or of the user request and system override.

* Added a Muted column to the CLI "confbridge list <conference>" command.

* Added a Muted header to the AMI ConfbridgeList action ConfbridgeList event.


Diffs
-----

  /branches/11/apps/confbridge/include/confbridge.h 401871 
  /branches/11/apps/confbridge/conf_state_single_marked.c 401871 
  /branches/11/apps/confbridge/conf_state_single.c 401871 
  /branches/11/apps/confbridge/conf_state_multi_marked.c 401871 
  /branches/11/apps/confbridge/conf_state_multi.c 401871 
  /branches/11/apps/confbridge/conf_state_inactive.c 401871 
  /branches/11/apps/confbridge/conf_state.c 401871 
  /branches/11/apps/app_confbridge.c 401871 

Diff: https://reviewboard.asterisk.org/r/2960/diff/


Testing
-------

Tested many unmarked/marked/waitmarked user combinations.
While MOH is playing, the effective muting is now always muted.
  Before:
    A user mute toggle request would immediately change the muting status.
    The initial user mute toggle would be different for the only unmarked or marked user in the conference if startmuted is no.
      It depended upon if MOH was playing or not.
While a waitmarked user is waiting for a marked user to join, the effective muting is always muted.
  Before:
    A user mute toggle request would effectively be ignored.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131102/634d09e9/attachment-0001.html>