[asterisk-dev] [Code Review] 2988: chan_sip creates a new local tag (from-tag) for every register message

Scott Griepentrog reviewboard at asterisk.org
Fri Nov 1 16:12:00 CDT 2013

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers, Jared Smith, Matt Jordan, Olle E Johansson, and Putnopvut.

Bugs: ASTERISK-12117

Repository: Asterisk


Added field to sip_registry structure to store a local (from) tag generated at the same time as callid, and assign that tag to sip_pvt structure used to generate REGISTER requests.  This aligns code with RFC 3261 "... request constitutes a new transaction and SHOULD have the same value of the Call-ID, To, and From of the previous request...".


  /branches/1.8/channels/sip/include/sip.h 402223 
  /branches/1.8/channels/chan_sip.c 402223 

Diff: https://reviewboard.asterisk.org/r/2988/diff/


Tests outbound_register_from and outbound_reregister_from added to testsuite/tests/channels/SIP and transition from Fail to Pass with this patch.


Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131101/6601a7c0/attachment.html>

More information about the asterisk-dev mailing list