[asterisk-dev] [Code Review] 2964: res_pjsip_outbound_registration: Add "virtual line" support for automatic inbound matching

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2964/#review10110
-----------------------------------------------------------


This is one of those features that I'm not really familiar with, so I don't know how widespread it is nor if it's implemented "correctly" (correctly is in quotation marks since there's no RFC for this behavior).

What's here mostly looks good. I would suggest only registering the endpoint identifier if any outbound registrations have "line" options set. The container retrieval from sorcery could be expensive, especially if it's going to always fail.

I also would recommend adding an integrity check for registration objects so that if a line is provided with no endpoint (or vice-versa), then a warning is emitted and the registration is not created.

- Mark Michelson


On Oct. 26, 2013, 1:55 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2964/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2013, 1:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds "virtual line" support to the res_pjsip_outbound_registration module. This is an optional feature and simply adds a "line" URI parameter to the Contact we place in the outbound registration. If this line parameter is present on incoming requests we use it to establish a relationship to the outbound registration and match it to a user configured endpoint. This has the benefit that when registering to another server where it is supported you no longer have to do IP based matching for all of their potential servers. The downside (and why this is optional) is that if a third party got the line parameter they could send you calls as if they were the legit remote server.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_outbound_registration.c 401280 
> 
> Diff: https://reviewboard.asterisk.org/r/2964/diff/
> 
> 
> Testing
> -------
> 
> Registered to an ITSP, placed an inbound call from them, confirmed matched using line parameter.
> 
> Registered to a chan_sip instance, placed an inbound call from it, confirmed matched using line parameter.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131101/3f01a857/attachment.html>