[asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2959/#review10097
-----------------------------------------------------------



branches/12/res/res_pjsip.c
<https://reviewboard.asterisk.org/r/2959/#comment19376>

    Getting different AMI events for different portions of a PJSIP endpoint is a different approach than any used previously. For this to work, I think we need to meet two requirements:
    
    1) Just as EndpointDetailComplete is the final event in the stream, EndpointDetail must be the first event.
    
    2) There must be an identifier that ties all of the events together. Ideally, this would be the name of the endpoint.



branches/12/res/res_pjsip/pjsip_configuration.c
<https://reviewboard.asterisk.org/r/2959/#comment19375>

    Per normal AMI conventions, the headers in an AMI event use CamelCase.
    
    So this should be ActiveChannels, Auths, DeviceState, etc.
    
    This applies to all AMI events constructed in this patch.


- Matt Jordan


On Oct. 31, 2013, 10:43 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2959/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 10:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22609
>     https://issues.asterisk.org/jira/browse/ASTERISK-22609
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Created the following AMI commands and corresponding events for res_pjsip:
> 
> PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few select attributes on each.
>   Events:
>     EndpointList - for each endpoint a few attributes
>     EndpointlistComplete - after all endpoints have been listed
> 
> PJSIPShowEndpoint - Provides a detail list of attributes for a specified endpoint
>   Events:
>     EndpointDetail - attributes on an endpoint
>     AorDetail - raised for each AOR on an endpoint
>     AuthDetail - raised for each associated inbound and outbound auth
>     TransportDetail - transport attributes
>     IdentifyDetail - attributes for the identify object associated with the endpoint
>     EndpointDetailComplete - last event raised after all detail events
> 
> PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound registrations
>   Events:
>     InboundRegistrationDetail - inbound registration attributes for each registration
>     InboundRegistrationDetailComplete - raised after all detail records have been listed
> 
> PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound registrations
>   Events:
>     OutboundRegistrationDetail - outbound registration attributes for each registration
>     OutboundRegistrationDetailComplete - raised after all detail records have been listed
> 
> PJSIPShowSubscriptions - A detail listing of all subscriptions and their attributes
>   Events:
>     SubscriptionDetail - on each subscription detailed attributes
>     SubscriptionDetailComplete - raised after all detail records have been listed
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_registrar.c 401958 
>   branches/12/res/res_pjsip_pubsub.c 401958 
>   branches/12/res/res_pjsip_outbound_registration.c 401958 
>   branches/12/res/res_pjsip_mwi.c 401958 
>   branches/12/res/res_pjsip_exten_state.c 401958 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 401958 
>   branches/12/res/res_pjsip/pjsip_configuration.c 401958 
>   branches/12/res/res_pjsip/location.c 401958 
>   branches/12/res/res_pjsip/include/res_pjsip_private.h 401958 
>   branches/12/res/res_pjsip/config_transport.c 401958 
>   branches/12/res/res_pjsip/config_auth.c 401958 
>   branches/12/res/res_pjsip.exports.in 401958 
>   branches/12/res/res_pjsip.c 401958 
>   branches/12/main/utils.c 401958 
>   branches/12/main/sorcery.c 401958 
>   branches/12/main/acl.c 401958 
>   branches/12/include/asterisk/strings.h 401958 
>   branches/12/include/asterisk/sorcery.h 401958 
>   branches/12/include/asterisk/res_pjsip_pubsub.h 401958 
>   branches/12/include/asterisk/res_pjsip.h 401958 
>   branches/12/include/asterisk/acl.h 401958 
> 
> Diff: https://reviewboard.asterisk.org/r/2959/diff/
> 
> 
> Testing
> -------
> 
> Ran a few manual tests over AMI and observed the output to make sure things look correct.  Also wrote some testsuite tests: https://reviewboard.asterisk.org/r/2958/
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131101/5d9f42bd/attachment-0001.html>