[asterisk-dev] [Code Review] 2574: Fixup hold/unhold with attended and blind transfers.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2574/
-----------------------------------------------------------

(Updated May 31, 2013, 12:34 a.m.)


Review request for Asterisk Developers, kmoore, Mark Michelson, and Jason Parker.


Changes
-------

Address kmoore's comments.


Repository: Asterisk


Description
-------

* DTMF attended and blind transfers have hold/unhold behavior restored.

* External attended and blind transfers unhold the transfered party when the transfer is initiated.

* Made prohibit blind transferring a bridge marked as masquerade only.  (ConfBridge bridges)

* Made running an application or playing a file inside a bridge post the hold/unhold messages if MOH is requested.


Diffs (updated)
-----

  /trunk/bridges/bridge_builtin_features.c 390174 
  /trunk/include/asterisk/bridging.h 390174 
  /trunk/include/asterisk/stasis_channels.h 390174 
  /trunk/main/bridging.c 390174 
  /trunk/main/channel.c 390174 
  /trunk/main/stasis_channels.c 390174 

Diff: https://reviewboard.asterisk.org/r/2574/diff/


Testing
-------

* Hold/unhold now works with DTMF attended and blind transfers.

* SIP attended and blind transfers stop MOH when the transfers are initiated.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130531/6dd8b416/attachment-0001.htm>