[asterisk-dev] [Code Review] 2575: Remove remnant of snapshot blob JSON types

jrose reviewboard at asterisk.org
Thu May 30 10:21:31 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2575/#review8727
-----------------------------------------------------------

Ship it!


Ship It!

- jrose


On May 30, 2013, 3:08 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2575/
> -----------------------------------------------------------
> 
> (Updated May 30, 2013, 3:08 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> I was poking around and noticed ast_bridge_blob_json_type was still around, a remnant of snapshot blobs having requisite type fields. Not only was it still around, it was still being used.  This removes usage of the once-mandatory snapshot blob type field, refactors confbridge stasis messages accordingly, and removes ast_bridge_blob_json_type().
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_confbridge.c 390037 
>   trunk/apps/confbridge/confbridge_manager.c 390037 
>   trunk/apps/confbridge/include/confbridge.h 390037 
>   trunk/include/asterisk/stasis_bridging.h 390037 
>   trunk/main/stasis_bridging.c 390037 
> 
> Diff: https://reviewboard.asterisk.org/r/2575/diff/
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130530/29fc72d4/attachment-0001.htm>


More information about the asterisk-dev mailing list