[asterisk-dev] [Code Review] 2569: Default state of 'meetme' hints should be Idle instead of Unavailable

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2569/#review8725
-----------------------------------------------------------


I'm not really happy with this change because for non-dynamic conference rooms it now lies. I think a better option would be to be able to specify whether to treat the conference room as dynamic or not. The returned value would then reflect the truth for both static and dynamic.

- Joshua Colp


On May 28, 2013, 6:23 p.m., Leif Madsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2569/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 6:23 p.m.)
> 
> 
> Review request for Asterisk Developers, Joshua Colp, Matt Jordan, and Mark Michelson.
> 
> 
> Bugs: ASTERISK-21828
>     https://issues.asterisk.org/jira/browse/ASTERISK-21828
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In Asterisk 1.8, we have an issue where on startup the default device state of 'meetme' hints is Unavailable. Ideally this should be 'Idle'. We've changed the code to make the default state NOT_INUSE instead of INVALID.
> 
> Also of note, this is a dynamic conference room via the 'd' option.
> 
> e.g.
> 
> exten => 100,1,MeetMe(fancyroom,1dqM)
> 
> 
> Diffs
> -----
> 
>   branches/1.8/apps/app_meetme.c 385521 
> 
> Diff: https://reviewboard.asterisk.org/r/2569/diff/
> 
> 
> Testing
> -------
> 
> Restarted Asterisk, noted the state was what we wanted.
> 
> 
> Thanks,
> 
> Leif Madsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130530/2838716d/attachment.htm>